Skip to content

PPPSYS-56851 Fix oauth thundering herd problems#34

Draft
DareYouS wants to merge 5 commits into
PPPSYS-56851-ruff-format-import-logsfrom
PPPSYS-56851-oauth-rate-limit-thundering-herd
Draft

PPPSYS-56851 Fix oauth thundering herd problems#34
DareYouS wants to merge 5 commits into
PPPSYS-56851-ruff-format-import-logsfrom
PPPSYS-56851-oauth-rate-limit-thundering-herd

Conversation

@DareYouS
Copy link
Copy Markdown

No description provided.

@DareYouS DareYouS requested a review from a team as a code owner May 12, 2026 10:17
@DareYouS DareYouS marked this pull request as draft May 12, 2026 12:16
@DareYouS DareYouS changed the base branch from master to PPPSYS-56851-packaging-ci-refresh May 13, 2026 11:04
@DareYouS DareYouS force-pushed the PPPSYS-56851-oauth-rate-limit-thundering-herd branch from e0b7967 to ead5954 Compare May 13, 2026 11:12
@DareYouS DareYouS changed the base branch from PPPSYS-56851-packaging-ci-refresh to PPPSYS-56851-ruff-format-import-logs May 13, 2026 12:11
@DareYouS DareYouS changed the title PPPSYS-56851 Extended CI Python matrix up to 3.14 PPPSYS-56851 Fix oauth thundering herd problems May 13, 2026
@pmajocha
Copy link
Copy Markdown
Contributor

But that doesn't improve anything beside waiting for the token. I would fix this by storing the token in a file together with the credentials. If subsequent calls to importer are made with the same credentials as in the file, we just use that token. The problem is repeating the import doesn't reuse token in between the calls, not the waiting for the rate limit itself. What is done here is okay, but I'd add some persistance through a file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants